Skip to content
This repository was archived by the owner on Nov 9, 2024. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export const tippy: typeof tippyCore;
export interface TippySingletonProps extends Partial<Props> {
children: Array<React.ReactElement<any>>;
className?: string;
plugins?: Plugin[];
}

export const TippySingleton: React.FunctionComponent<TippySingletonProps>;
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
},
"dependencies": {
"prop-types": "^15.6.2",
"tippy.js": "^5.0.1"
"tippy.js": "^5.0.2"
},
"peerDependencies": {
"react": ">=16.8",
Expand Down
3 changes: 2 additions & 1 deletion src/TippySingleton.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
export default function TippySingleton({
children,
className,
plugins,
ignoreAttributes = true,
...restOfNativeProps
}) {
Expand All @@ -25,7 +26,7 @@ export default function TippySingleton({

useIsomorphicLayoutEffect(() => {
const {instances} = component;
const instance = createSingleton(instances, props);
const instance = createSingleton(instances, props, plugins);

component.instance = instance;

Expand Down
3 changes: 2 additions & 1 deletion src/hooks.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export function useInstance(initialValue) {

export function useSingleton({
className,
plugins,
ignoreAttributes = true,
...restOfNativeProps
} = {}) {
Expand All @@ -49,7 +50,7 @@ export function useSingleton({

useIsomorphicLayoutEffect(() => {
const {instances} = component;
const instance = createSingleton(instances, props);
const instance = createSingleton(instances, props, plugins);

component.instance = instance;

Expand Down
17 changes: 17 additions & 0 deletions test/TippySingleton.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,23 @@ describe('<TippySingleton />', () => {

expect(tooltip.classList.contains('one')).toBe(true);
});

test('props.plugins', () => {
const plugins = [{fn: () => ({})}];

render(
<TippySingleton plugins={plugins}>
<Tippy content="tooltip">
<button />
</Tippy>
<Tippy content="tooltip">
<button />
</Tippy>
</TippySingleton>,
);

expect(instance.plugins).toEqual(plugins);
});
});

describe('TippySingleton.propTypes', () => {
Expand Down
26 changes: 26 additions & 0 deletions test/useSingleton.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -201,4 +201,30 @@ describe('The useSingleton hook', () => {
singletonInstance.popperChildren.tooltip.classList.contains('one'),
).toBe(true);
});

test('props.plugins', () => {
const plugins = [{fn: () => ({})}];

function App() {
const singleton = useSingleton({
plugins,
onCreate(instance) {
expect(instance.plugins).toEqual(plugins);
},
});

return (
<>
<Tippy content="tooltip" singleton={singleton}>
<button />
</Tippy>
<Tippy content="tooltip" singleton={singleton}>
<button />
</Tippy>
</>
);
}

render(<App />);
});
});