This repository was archived by the owner on Nov 9, 2024. It is now read-only.
Support enabled prop in singletons
#138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned before,
visibledoesn't make sense for singletons, butenableddoes. But this brings up an interesting problem: how do you makevisibleorenabledwork for sub-tippies that are part of the singleton? I think withgroup, that previously worked since they were individual instances. This probably requires changes in core.Since there's now common code, I've extracted these into separate hooks and created
util-hooks(used internally) andhooks(exported by the package) directories.