Filter __source and __self dev props

[CPatchane]

👋

Those props are added by babel-preset-react in dev environment (by @babel/plugin-transform-react-jsx-self and @babel/plugin-transform-react-jsx-source)
Documentation: https://babeljs.io/docs/en/babel-preset-react/

But they are passed directly to tippy and currently we have the warnings everywhere I am using it in my development environment:

[atomiks]

Can't you create a wrapper component that filters these out? I think this issue came up a while ago and that solved it.

i.e.

export default forwardRef(({__source, __self, ...props}, ref) => {
  return <Tippy {...props} ref={ref} />;
});

[CPatchane]

I just tried it seems to not working in my code, I still have warnings :/

Is it the wrong place to remove it here? Since this is a dedicated React wrapper for Tippy, this could be the good place to handle it or I am wrong?

[atomiks]

Well the problem is how many other rogue props need to be handled? Not just from those plugins. If it works for the user to create a wrapper to handle their problem case then that would be better.

If these are the most common plugins though, then I guess it would be okay unless there are any more of them. (Maybe move the delete to destructured arguments?)

[CPatchane]

I see your point, if it can help I found that in the React source code https://github.com/facebook/react/blob/d3622d0f977def825123f1d5f4cef19888b1eaf1/packages/react/src/ReactElement.js#L16

For me those props seems to be an implementation detail so we should not be aware how to handle it using Tippy (I am curious that I don't find any other issues about that btw).

[CPatchane]

@atomiks Do you prefer to use the destructured arguments to remove them? You won't have any linting errors about unused variables?

[atomiks]

Do you prefer to use the destructured arguments to remove them?

I think so, the linter doesn't seem to complain for me

config has this 'no-unused-vars': ['error', {ignoreRestSiblings: true}],

[CPatchane]

@atomiks It's done ;)

[atomiks]

Thank you!