This repository was archived by the owner on Nov 9, 2024. It is now read-only.
fix: extract deps to constant #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a mistake here as we weren't passing the dep in an array, rather by itself. (We need that TypeScript rewrite asap 😅)
Babel loose mode uses
className.concat(dep)so that's why there is no error when using the package (i.e. the dependency array was equivalent to not being there at all - re-running every time for component children since it was concating the forwardRef object), but there's an error in the demo when using a component as a child - not sure why the transform is different there.It also doesn't error in the tests because of the babel transform, I think.