Skip to content
This repository was archived by the owner on Nov 9, 2024. It is now read-only.

Conversation

@lgraziani2712
Copy link
Contributor

Instead of limiting the elements to one string or one react element, would be better if it allows one (string, number, or react element) or an array of them.

Which, actually, it already works.

Instead of limiting the elements to one string or one react element, would be better if it allows one (string, number, or react element) or an array of them.

Which, actually, it already works.
@atomiks
Copy link
Owner

atomiks commented Jun 6, 2019

One last thing. Can we wrap the propTypes assignment in a block like this

if (process.env.NODE_ENV !== 'production') {
  Tippy.propTypes = {...}
}

I noticed that CRA doesn't remove it from the production bundle by default

This will prevent adding PropTypes to production!
@lgraziani2712
Copy link
Contributor Author

I was thinking about that but I was going to ask about in another issue heh.

Done!

@atomiks
Copy link
Owner

atomiks commented Jun 7, 2019

Thank you. I think we need to adjust the rollup build file for the UMD version to work properly in a browser environment, it shouldn't be too difficult as I did it for tippy.js itself recently

@atomiks atomiks merged commit 727d573 into atomiks:master Jun 7, 2019
@atomiks
Copy link
Owner

atomiks commented Jun 13, 2019

Looks like the propType for content is causing problems :s...

@atomiks atomiks mentioned this pull request Jun 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants