This repository was archived by the owner on Aug 8, 2025. It is now read-only.
Rename to GoalInvocation; deprecate status#2
Merged
Conversation
cdupuis
suggested changes
Jul 3, 2018
| branch:nortissej:bb-curl-or-axios | ||
| branch:nortissej:custom-seed | ||
| branch:nortissej:keep-log-newlines | ||
| branch:reg-simplification |
| import { | ||
| BuildStatus, | ||
| OnBuildComplete, | ||
| OnBuildComplete, SdmGoalState, |
Contributor
Author
There was a problem hiding this comment.
that can be an autofix, that is not worth our personal attention
| const progressLog = new WriteToAllProgressLog(sdmGoal.name, new LoggingProgressLog(sdmGoal.name, "debug"), log); | ||
| const addressChannels = addressChannelsFor(commit.repo, ctx); | ||
| const id = params.repoRefResolver.repoRefFromSdmGoal(sdmGoal, await fetchProvider(ctx, sdmGoal.repo.providerId)); | ||
| const id = params.repoRefResolver.repoRefFromSdmGoal(sdmGoal, await fetchProvider(ctx, undefined)); |
Contributor
Author
There was a problem hiding this comment.
I deprecated the argument but until that percolated through the compiler wanted to see it
Contributor
Author
There was a problem hiding this comment.
I can remove it now.
| import { StatusForExecuteGoal } from "@atomist/sdm/typings/types"; | ||
| import { readSdmVersion } from "../../internal/delivery/build/local/projectVersioner"; | ||
| import { postLinkImageWebhook } from "../../util/webhook/ImageLink"; | ||
| import { ExecuteGoal, PrepareForGoalExecution, GoalInvocation } from "@atomist/sdm"; |
cdupuis
changed the title
cdupuis
added
the
changelog:deprecated
cdupuis
approved these changes
Jul 3, 2018
[atomist:generated]
[atomist:generated]
cdupuis
force-pushed
the
nortissej/deprecate-status
branch
from
7ad5491 to
fd2e884
Compare
cdupuis
added
enhancement
atomist-bot
added a commit
that referenced
this pull request
Jul 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on atomist/sdm#426