This repository was archived by the owner on Aug 8, 2025. It is now read-only.
Rename to GoalInvocation; deprecate status#426
Merged
Conversation
The message is what we store; the event is what we receive from subscriptions or queries
jessitron
requested review from
cdupuis and
johnsonr
and removed request for
cdupuis
cdupuis
suggested changes
Jul 3, 2018
Member
cdupuis
left a comment
cdupuis
left a comment
There was a problem hiding this comment.
Please don't merge. I'll add some changes on top of that.
cdupuis
changed the title
cdupuis
added
the
changelog:deprecated
Member
|
@jessitron you want to merge this before killing the status field? or after? |
Contributor
Author
|
all downstream things can use status, don't remove it yet |
Member
|
what about sdmGoal -> Push -> imageLink? we don't have that right now. That needs to be added. |
cdupuis
approved these changes
Jul 3, 2018
| constructSdmGoalImplementation, | ||
| storeGoal, | ||
| } from "./storeGoals"; | ||
| import { SdmGoalFulfillment, SdmGoalMessage } from "../../api/goal/SdmGoalMessage"; |
the index showing up in the package doesn't match the one I see here
[atomist:generated]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a step in the direction of #408
The duplication in SdmGoalMessage and SdmGoalEvent is part deliberate (the Message really is its own type, for updating and storage) and part a workaround: I'd rather use a generated-from-graphql type for the event, but none of the fields are required, and we can't make them required yet. Once we can, we should be able to replace that type with an alias to a generated one.