Conversation
tbruyelle
requested review from
adam-hanna,
giunatale and
jaekwon
as code owners
tbruyelle
changed the title
- no need to Sleep after runValidators since everything has been checked. - Eventually always waits for tick before evaluating the condition function, so reducing tick improve exec speed.
bc better error handling
tbruyelle
force-pushed
the
tbruyelle/test/improve-e2e
branch
from
ab420c3 to
f1c1864
Compare
Backported from more recent version of Gaia, since the gov sub-params became deprecated, there's no reason to prevent requesting the gov params without a param type.
tbruyelle
force-pushed
the
tbruyelle/test/improve-e2e
branch
from
f3dabd2 to
945497f
Compare
registration became required since we parse the tx query response.
giunatale
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main benefit of this change is to print the node logs when no blocks are produced. For that, because the nodes are running in a docker container, the docker API logs is requested.
Also:
t.Run()appropriately: some calls were irrelevant, like when they are used to execute a command which is a part of a test case.Eventuallytick parameter/atomone.gov.v1.Paramsquery so it doesn't return an error if paramType is not provided (see 945497f)