ESP32: use single precision floats for performance reasons#1082
Closed
bettio wants to merge 1 commit intoatomvm:mainfrom
Closed
ESP32: use single precision floats for performance reasons#1082bettio wants to merge 1 commit intoatomvm:mainfrom
bettio wants to merge 1 commit intoatomvm:mainfrom
Conversation
Documentation says: "Avoid using double precision floating point arithmetic double. These calculations are emulated in software and are very slow. If possible then use an integer-based representation, or single-precision floating point." Signed-off-by: Davide Bettio <davide@uninstall.it>
UncleGrumpy
approved these changes
Mar 1, 2024
Collaborator
UncleGrumpy
left a comment
UncleGrumpy
left a comment
There was a problem hiding this comment.
This looks good. I have been wanting to see this change for a while.
Collaborator
|
I did some testing, and as you mentioned in the Telegram group, this makes little difference in performance. Either Espressifs documentation is misleading, or there is something else preventing the hardware FPU from being used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation says: "Avoid using double precision floating point arithmetic double. These calculations are emulated in software and are very slow. If possible then use an integer-based representation, or single-precision floating point."
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later