Fix a binary corruption bug occurring with private_append #2004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a binary is small enough to be on heap and private_append is used for binary construction, a new binary is created and it needs to be zero'd if further binary construction instructions only set bits. Fixes atomvm#2003 Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot
force-pushed
the
w48/fix-private_append-corruption
branch
from
844d2a1 to
635f2dc
Compare
bettio
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a binary is small enough to be on heap and private_append is used for binary construction, a new binary is created and it needs to be zero'd if further binary construction instructions only set bits.
Fixes #2003
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later