Conversation
2e49a5e to
1afc2ff
Compare
|
Thank you for this contribution! This looks great, and should work just fine on Pico W chips as well as ESP32. I will test soon and make sure, before we have you update the README and adjust |
UncleGrumpy
left a comment
There was a problem hiding this comment.
Just a couple minor details. This will also work for wifi enabled pico devices, just one minor code change needed. Also lets keep the directory and app name consistent with the other Elixir examples.
|
I realize LEDC_Example has doesn't follow the correct naming scheme, I take responsibility for that! I should submit a fix to rename it, and update it to use Elixir IO - AtomVM added support for it since the ledc example was added here. |
There was a problem hiding this comment.
This looks great! Thank you! One last little nit-picky request. Can you flatten (or squash) your commits into a single commit? All of the AtomVM org repos like to keep a clean git history, we do not need the extra review requested changes in the log.
3101c58 to
9e346ce
Compare
UncleGrumpy
left a comment
There was a problem hiding this comment.
Thank you again for the contribution!
Add an Elixir WifiExample that mirrors the Erlang wifi example (STA + AP configuration + SNTP sync) and document it alongside the other Elixir examples.
I tested this example with my ESP32-S3.
The log output looks like this: