Retain OTP29 Recs chunks#63
Merged
Merged
Conversation
Signed-off-by: Paul Guyot <pguyot@kallisys.net>
Collaborator
|
Do you think this should have a test added before we merge? |
Collaborator
Author
|
I can write a test that verifies this is indeed the name of the chunk OTP29 emits but is it over-engineering? |
Collaborator
That’s why I asked you, I don’t think we really need a test for this now. I was just thinking about catching any regression in the future that might cause the chunks to be excluded. But again that is probably unlikely and can be dealt with later if a problem does arise. |
UncleGrumpy
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.