feat(maps): persist the Incuna Sam objective - #63
Merged
Conversation
zoeyrose
marked this pull request as ready for review
August 10, 2026 10:20
This was referenced Aug 10, 2026
zoeyrose
added a commit
that referenced
this pull request
Aug 10, 2026
## Summary - forward-port the reviewed Incuna arrival and Sam objective from `1.x` PR #63 - start Lost Memories on both guarded Incuna arrival decks after Escaping the Deserted Island - preserve legacy quest dispatch, active/completed/failed saves, and one-time Sam reward behavior - carry the native arrival, transition, repeat-arrival, and legacy-save regression suite to `main` ## Release-line relationship This is the independently validated `main` companion to merged maintenance PR #63. The patch ID and all six resulting file blobs are identical to the merged `1.x` change, and the affected pre-change content was already identical across the two release lines. No release branch was merged wholesale and no generated output was copied. `main` is the canonical issue-closing PR. The merged `1.x` companion is #63. ## Validation - `PYTHONDONTWRITEBYTECODE=1 python3 tools/validate.py` — 90 tests; content core, schema, catalog, contracts, syntax, collection, provenance, and runtime checks passed - `python3 -m tools.content_catalog validate --root .` - `python3 tools/world_content_audit.py quests` - `python3 -m compileall -q maps/python tools` - `git diff --check` Gameplay validation for the byte-identical authored behavior was completed on the Classic `1.x` companion before #63 merged, including the full tutorial voyage, message-window churn, relog persistence, the correct Incuna Sam transition, and repeat voyages. The replacement `main` stack does not yet expose an integrated playable wrapper runtime, so no incompatible Classic runtime was routed through this branch. Closes #57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lost Memories/Speak with Sam Goodberryobjective when a player first reaches Incuna after completingEscaping the Deserted IslandThe Priestpart before completing the handoff1.xquest state without duplicate parts or rewardsCompatibility
The arrival script requires both a completed Deserted Island quest and no existing Lost Memories object. The new
speak_sampart is authored after every legacy part so InterfaceBuilder's first-match dispatch remains unchanged for existing saves. Repeated arrivals and active/completed/failed legacy records are no-ops.Coordinates
1.xat8b50df52355ae6ae4d529838272e41b5d678c84bfeat/57-incuna-sam-objectiveat5f9092bf45f7e36b6240bc6132ddd12fce09aeaa00c01c00 feat(maps): persist the Incuna Sam objectivec1b91c52 fix(maps): preserve the Incuna Sam fallbackd7dcb25b fix(maps): protect active Lost Memories saves3bd9a55b fix(maps): trigger the first Incuna objective90ff5f77 test(maps): cover Lost Memories arrival triggersab1c8ba2 fix(maps): preserve legacy Lost Memories dispatch5f9092bf test(maps): harden Lost Memories compatibilityValidation
python3 tools/validate.py— 86 tests plus archetype, map, catalog, contract, collection, runtime, and release checks passpython3 tools/world_content_audit.py quests— passpython3 -m compileall -q maps/python tools— pass./atrinik build server --profile issue-57-incuna-sam --test— the managed CTest command reports 36/36, including worldmaker,server-assetspath-migration, and protocol checksgit diff --check 8b50df52355ae6ae4d529838272e41b5d678c84b...HEAD— passClassic's existing Python-plugin CTest adapter currently returns success even though the full embedded log contains two unrelated baseline failures in unchanged tests. All five issue-owned cases are individually logged
okin that full run and pass together in a filtered run. The upstream result-propagation defect is outside this content diff; no passing claim here relies on those unrelated cases.Gameplay verification
An isolated fresh
basic-playerscenario on the maintained1.xstack completed the ordinary Deserted Island quest and voyage. Before speaking to Sam, the journal contained exactly one active Sam objective. It remained after 170/timemessages filled the 150-message window and after a clean QUIC relog. Talking to the Sam on/shattered_islands/world_4_85completed that part and startedThe Priest.The scenario used wrapper-owned
runtime/assets/{data,client-maps}through--assetspath; region maps and client assets were delivered by the server's QUIC asset path. No legacyhttp/datastate or HTTP runtime option was created or used. The server topology was stopped and the scenario reset after verification.Review
Iterative complete-diff review found and fixed the missing first-arrival map trigger, missing-quest fallback, active-save protection, legacy InterfaceBuilder ordering, and durable compatibility-test gaps. The final fresh review pass at
5f9092bffound zero actionable content findings.Closes #57