Skip to content

At talk for java#385

Merged
gkc merged 2 commits intotrunkfrom
at_talk_for_java
Apr 9, 2026
Merged

At talk for java#385
gkc merged 2 commits intotrunkfrom
at_talk_for_java

Conversation

@akafredperry
Copy link
Copy Markdown
Collaborator

@akafredperry akafredperry commented Apr 4, 2026

closes #328
closes #382

- What I did

  • New module (not published) for at_talk. This illustrates subscribing to decrypted value events and demonstrates sending notify key updates
  • Modifications to the monitoring support in AtClientImpl. The withMonitoring() builder option allows monitoring from construction and avoid having to invoke startMonitor(). MonitorOptions makes all the verb parameters available in Java api.

- How I did it

  • Created MonitorOptions.java to model monitor verb parameters.
  • Add withMonitoring() to AtClients builder.
  • New module at_talk that generates a fatjar (see README)
  • AtClientContext can now be simplified, can now use epochMillis (rather than a pause and discard) to prevent tests from "bleeding into each other".

- How to verify it

  • Clean install, follow README instructions for at_talk
  • Have tested with dart at_talk
  • New features have test coverage and all unit and integration tests run as part of this pipeline

- Description for the changelog

feat: at_talk cli

@akafredperry akafredperry force-pushed the at_talk_for_java branch 4 times, most recently from d0bf3bd to 2dec7ef Compare April 4, 2026 08:49
@akafredperry akafredperry marked this pull request as ready for review April 4, 2026 10:01
@akafredperry akafredperry requested a review from gkc April 4, 2026 10:01
@akafredperry akafredperry self-assigned this Apr 4, 2026
Comment thread at_client/src/main/java/org/atsign/client/impl/commands/CommandBuilders.java Outdated
Comment thread at_client/src/main/java/org/atsign/client/impl/commands/MonitorOptions.java Outdated
@akafredperry
Copy link
Copy Markdown
Collaborator Author

this branch is now rebase with trunk

Copy link
Copy Markdown
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gkc gkc merged commit cd0c0c8 into trunk Apr 9, 2026
4 checks passed
@akafredperry akafredperry deleted the at_talk_for_java branch April 9, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement at_talk in Java Monitor threadpool should be configurable

2 participants