This repository was archived by the owner on Jul 24, 2019. It is now read-only.
Use Upstream Memcached Image#109
Merged
alanmeadows merged 2 commits intoatt-comdev:masterfrom Jan 20, 2017
portdirect:upstream/memcached
Merged
Use Upstream Memcached Image#109alanmeadows merged 2 commits intoatt-comdev:masterfrom portdirect:upstream/memcached
alanmeadows merged 2 commits intoatt-comdev:masterfrom
portdirect:upstream/memcached
Conversation
This commit changes the default Memcached Image to the Upstream: * https://hub.docker.com/_/memcached/
DTadrzak
reviewed
Jan 13, 2017
| # name: value | ||
|
|
||
| images: | ||
| memcached: quay.io/stackanetes/stackanetes-memcached:newton |
Collaborator
There was a problem hiding this comment.
Let's pin to particular version.
Contributor
There was a problem hiding this comment.
Agreed. Latest should be avoided for reliable repeatability. Suggest 1.4.34.
alanmeadows
suggested changes
Jan 19, 2017
Contributor
alanmeadows
left a comment
alanmeadows
left a comment
There was a problem hiding this comment.
Pete, a good change toward normalizing the images. I agree we should pin the version for guaranteed consistency.
alanmeadows
approved these changes
Jan 20, 2017
Contributor
|
Reviewed 1 of 1 files at r2. Comments from Reviewable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the default Memcached Image to the upstream one from the Docker Hub:
This change is