This repository was archived by the owner on Jun 16, 2025. It is now read-only.
Enable test cases for standard commands#500
Merged
siteshwar merged 5 commits intoatt:masterfrom May 5, 2018
siteshwar:gh499
Merged
Enable test cases for standard commands#500siteshwar merged 5 commits intoatt:masterfrom siteshwar:gh499
siteshwar merged 5 commits intoatt:masterfrom
siteshwar:gh499
Conversation
Contributor
Author
|
It fails to compile on opensuse because it uses an older version of glibc: This error was removed and support for large files was added through this commit in glibc. But for now I think we should disable |
Contributor
Author
|
I think this should be fixed in Meson. I have opened an issue for it mesonbuild/meson#3519 |
Older versions of glibc do not have support for -D_FILE_OFFSET_BITS=64 in fts functions. This flag is enabled by default in all meson builds. Add a feature test for this macro and disable it if fts functions do not support it.
Contributor
|
Fails with the following one or both of the following errors on macOS, opensuse and ubuntu 16.04: |
Contributor
Author
|
@krader1961 Fixed. |
If .sh.op_astbin is changed, shell builtins will be bound to path specified by it. This test case fails on systems that do not have cmp and basename under /bin directory, so fix it's expected output. Related: #499
Contributor
|
LGTM, in as much as it no longer introduces new test failures on the platforms I'm testing against 😄 Also, I have no objection to the text of the change. But I'm far from happy about how builtin commands of this sort are exposed and tested. That, however, is a discussion for another day. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.