Error message spills outside of the box

[prateek032]

Steps to reproduce;

• Open any history version notebook
• Copy the notebook Id (eg: 25458a622e71ee596d896f4a553ba697&version=df1e584a2cf0d32e8f760c8569816519b0f0ee4c)
• Open Pull and Replace from notebook and paste the copied content in Notebook ID field
• then click on pull

[gordonwoodhull]

Thanks @prateek032. That's invalid because the dialog only expects an id, not a fragment of a query string.

So we should validate this field against a regexp and provide a more helpful error.

But we should also consider adding a version field for the notebook id option, and parsing of the version for the URL option. Maybe not for 1.7 but as a follow-up.

[shaneporter]

Submitted a PR for this, #2329.

I believe the 'version' work should be added to a new enhancement issue, since it is outside of the scope of the initial 'pull and replace' enhancement changes.

[gordonwoodhull]

Thanks for the reminder, added another issue for later.

[prateek032]

This issue is still reproducible on Firefox browser

[gordonwoodhull]

Well, that's a different issue because it's the file chooser - I'll move it.