Deny unknown/unscorable versions instead of crashing#12
Merged
Conversation
When GetPackageScore returns an error (e.g. 404 for a non-existent or unpublished version), return a deny result instead of propagating the error as a fatal crash. Fail closed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a pinned version cannot be scored (404 from Socket API — e.g. unpublished malware), the binary crashed with a fatal error instead of denying. Now it returns a deny decision.
Before
npm install axios@0.14.1-> error: evaluating axios: API returned status 404After
npm install axios@0.14.1-> deny: could not score axios@0.14.1Test plan
Generated with Claude Code