[codex] Handle Claude plugin config token env names#13
Merged
Conversation
Collaborator
Author
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the plugin token handoff for Claude Code plugin installs by accepting the manifest key form that Claude documents for
userConfigenvironment variables.What Changed
CLAUDE_PLUGIN_OPTION_socket_api_tokeninplugin/hooks/bootstrap.shCLAUDE_PLUGIN_OPTION_SOCKET_API_TOKENpath as a compatibility fallbackSOCKET_API_TOKENclaude --plugin-dir ./plugindevelopment may require manually exportingSOCKET_API_TOKENRoot Cause
The plugin manifest key is
socket_api_token, but the bootstrap wrapper only checked the fully uppercased env var name. If Claude exposes the config using the documented<KEY>form without uppercasing, the wrapper misses the token and hard-fails even though the user supplied it.Validation
go test ./plugingo test ./...go vet ./...go build ./...env -u SOCKET_API_TOKEN CLAUDE_PLUGIN_OPTION_socket_api_token=test-token plugin/hooks/bootstrap.sh version