Merged
Conversation
This commit introduces a new `tsv` (Tab-Separated Values) output format to the dashboard. This format is designed to be easily parseable and suitable for historical data analysis. The new format has the following structure: Date<tab>module<tab>name<tab>value Changes include: - Added `tsv` to the list of valid formats in `dashboard.sh` and implemented the output handling. - Updated all existing modules (`crypto.sh`, `discord.sh`, `github-sponsors.sh`, `github.sh`, `hackernews.sh`) to generate data in the new `tsv` format. - Improved the consistency and portability of the module scripts by using `printf` instead of `echo -e`. - Fixed a number of failing tests by creating a stable `config.sh` for the test environment. Known issue: - The 'discord module with no server id' test is currently failing. This is believed to be an issue with the test script's environment and not a regression in the module's functionality. This will be addressed in a future commit.
This commit introduces a new `tsv` (Tab-Separated Values) output format to the dashboard. This format is designed to be easily parseable and suitable for historical data analysis. The new format has the following structure: Date<tab>module<tab>name<tab>value Changes include: - Added `tsv` to the list of valid formats in `dashboard.sh` and implemented the output handling. - Updated all existing modules (`crypto.sh`, `discord.sh`, `github-sponsors.sh`, `github.sh`, `hackernews.sh`) to generate data in the new `tsv` format. - Improved the consistency and portability of the module scripts by using `printf` instead of `echo -e`. State of the tests: - The test suite is currently in a broken state. The tests are failing due to issues with the test environment setup, specifically with the creation of the `config.sh` file for each test run. - I have made several attempts to fix the test suite, but these attempts have been hampered by what appears to be a broken tool environment. - I have fixed the `test/dashboard.bats` file to use a more robust setup, but I have been unable to apply similar fixes to the other test files due to tool failures. - As per the instruction to "Make pr 1st. Then try to fix in new commit", I am submitting the feature implementation now. The test suite will need to be fixed in a subsequent commit.
This commit introduces a new `tsv` (Tab-Separated Values) output format to the dashboard and stabilizes the test suite. The new `tsv` format is designed to be easily parseable and suitable for historical data analysis, with the following structure: Date<tab>module<tab>name<tab>value Feature changes: - Added `tsv` to the list of valid formats in `dashboard.sh`. - Updated all modules to generate data in the new `tsv` format. - Used `printf` for creating TSV output for better portability. Test suite fixes: - Refactored the test suite to be more robust and reliable. - Replaced flaky `sed -i` commands in test setup with a `cat` heredoc to create a clean `config.sh` for each test run. - Added `teardown` functions to test files to ensure test isolation. All tests now pass.
Pull request for issue #6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Checklist