Skip to content

Comments

add healthcheck using netcat and sed#2451

Open
mortee wants to merge 5 commits intoatuinsh:mainfrom
mortee:healthcheck
Open

add healthcheck using netcat and sed#2451
mortee wants to merge 5 commits intoatuinsh:mainfrom
mortee:healthcheck

Conversation

@mortee
Copy link

@mortee mortee commented Nov 19, 2024

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

@mateuscomh
Copy link
Contributor

@mortee suggestion: great idea implement heathcheck. But to optimize the image size and reduce unnecessary dependencies, consider replacing curl and jq with netcat (nc) in the health check. This change will minimize the number of packages installed in the final runtime image and improve efficiency.

@mortee mortee changed the title add healthcheck using curl and jq add healthcheck using netcat and sed Dec 4, 2024
@mortee
Copy link
Author

mortee commented Apr 2, 2025

I updated this to use the /healthz endpoint added in #2549. Can this now be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants