Implement Brian's feedback from PR #12#15
Merged
robdimarco-atxp merged 3 commits intomainfrom Aug 21, 2025
Merged
Conversation
- Rename packages from atxp-sqlite-db to atxp-sqlite and atxp-redis-db to atxp-redis - Remove oAuthDb.ts and oAuthDbFactory.ts files as they are no longer needed - Update all documentation and references to use new package names - Replace factory pattern with direct database instance creation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
badjer
approved these changes
Aug 21, 2025
- Update main README.md to reference new package names (@atxp/sqlite instead of @atxp/sqlite-db) - Regenerate package-lock.json to resolve npm ci failures 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Update build script to use new package names (atxp-sqlite, atxp-redis) - Update test:integration script to reference correct package 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
atxp-sqlite-dbtoatxp-sqliteandatxp-redis-dbtoatxp-redisoAuthDb.tsandoAuthDbFactory.tsfiles as they are no longer neededTest plan
🤖 Generated with Claude Code