Conversation
badjer
commented
Aug 26, 2025
| import { createBaseAccountSDK } from "@base-org/account"; | ||
| import { requestSpendPermission } from "@base-org/account/spend-permission"; | ||
|
|
||
| export const USDC_CONTRACT_ADDRESS_BASE = "0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913"; // USDC on Base mainnet |
Contributor
Author
There was a problem hiding this comment.
Contributor
|
The individual READMEs for each package were displayed on the npmjs.org page for each package. As long as this results in the top-level README being used for each package, I don't see any issues with this approach. It is just important that we have something for each individual package. |
Contributor
|
The READMEs in the examples are good to have, and the non-README |
…p/base package" This reverts commit ba00219.
badjer
force-pushed
the
bdj/delete-readmes
branch
from
5ba50be to
5981e49
Compare
Signed-off-by: zach wick <zwick@novellum.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @zachwick
There's still some non-README
.mddocs in the repo, as well as README.mds in the examples - I haven't touched those. LMK if we should :)