Remove destination() method and use /addresses endpoint exclusively#84
Merged
robdimarco-atxp merged 1 commit intomainfrom Oct 1, 2025
Conversation
- Remove destination() from PaymentDestination interface - Remove destination() from ChainPaymentDestination and ATXPPaymentDestination - Update requirePayment to only call destinations() - Update all tests to use destinations() instead of destination() All SDK calls now use /addresses endpoint exclusively 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
robdimarco-atxp
deleted the
robdimarco/atxp-339-modify-the-sdk-to-no-longer-call-the-destination-route
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
destination()method from the PaymentDestination interface and implementations, making the SDK use only the/addressesendpoint for all payment destination lookups.Changes
destination()method, now only hasdestinations()destination()implementation, simplifieddestinations()to return array directlydestination()implementation that was calling/destinationendpointdestinations()destinations()and expect arraysTest Results
✅ All 126 tests in atxp-server package pass
Related
Closes ATXP-339
🤖 Generated with Claude Code