Skip to content

feat: AI-First Dotfiles Enhancement Sprint (5 features)#1114

Merged
atxtechbro merged 5 commits intomainfrom
feature/ai-first-sprint-1106
Aug 1, 2025
Merged

feat: AI-First Dotfiles Enhancement Sprint (5 features)#1114
atxtechbro merged 5 commits intomainfrom
feature/ai-first-sprint-1106

Conversation

@atxtechbro
Copy link
Owner

Git Statistics

5 commits, 17 files changed, 257 insertions(+), 338 deletions(-)

Summary 🎯

This master PR consolidates the complete AI-First Dotfiles Enhancement Sprint (#1106) - transforming developer workflows through 5 carefully orchestrated improvements. Each change builds on the next to create a cohesive system that amplifies productivity while reducing cognitive load.

Closes #1106

The 5 Features in Order of Impact 📈

1. 🧠 Token Efficiency Optimization (#1098)

91% reduction in preloaded content - from 389 lines to 35 lines

  • Moved detailed procedures to docs/procedures/
  • Knowledge procedures now act as signposts, not encyclopedias
  • Dramatic reduction in AI context window usage
  • Impact: Every AI interaction starts cleaner and faster

2. 🔄 Formalized Post-PR Mini Retro (#1102)

From 3-line stub to comprehensive 72-line procedure

  • Agent-led collaborative process with human participation
  • Comprehensive questions covering tools, principles, and tensions
  • Personality-driven focus (Jonah for constraints, Brent for heroics)
  • Impact: Continuous improvement becomes systematic, not accidental

3. 📝 Smart GitHub Issue Creation (#1100)

Context-aware issue templates with automatic procedure injection

  • New /create-issue slash command
  • Smart template selection based on keywords
  • Links relevant procedures based on context
  • Impact: Issues start with the right structure and guidance

4. 🌱 Eager Evolution Principle (#1104)

Renamed continuous-improvement to capture "living system" essence

  • Systems that actively seek their own evolution
  • Like a plant growing toward light, not just incremental changes
  • Updated 7 files to use new terminology
  • Impact: Mindset shift from passive improvement to active evolution

5. 🔧 Git MCP Tool Fix (#1103)

Fixed git_add to properly handle deleted files

  • Now checks if files are tracked by git, not just disk existence
  • Enables proper staging of deletions in worktree workflows
  • Self-healing through MCP error reporting procedure
  • Impact: Removes friction from git workflows, especially with file deletions

Review Guide 🗺️

Each feature was implemented in its own PR for focused review:

This master PR cherry-picks all commits for a holistic view of the sprint's impact.

The Compound Effect 🚀

Together, these changes create a flywheel effect:

  1. Less tokens → Faster AI responses → More iterations possible
  2. Better retros → Captured learnings → Improved procedures
  3. Smart issues → Clear starting points → Less wasted effort
  4. Eager evolution → Proactive improvement → Living systems
  5. Fixed tools → Less friction → More flow state

Testing Performed ✅

  • Token reduction verified by line count analysis
  • Post-PR retro tested in real feature work
  • Issue creation workflow validated with multiple templates
  • Principle rename verified across all references
  • Git tool fix tested with file deletion scenarios

What's Next? 🔮

This sprint establishes the foundation for:

  • Further token optimizations in other directories
  • Additional consultant personalities for retros
  • More sophisticated issue template intelligence
  • Deeper integration of eager evolution principle
  • Extended MCP tool self-healing patterns

Reviewer tip: Each commit tells its own story. Review commit-by-commit to see the progression, or review by file to see the cumulative impact. The choice is yours! 🎨

Move detailed content from knowledge/ to docs/ and .github/ISSUE_TEMPLATE/
to reduce token usage in every Claude Code session. Knowledge procedures
now follow concise pattern: philosophy, when to use, link to details.

Optimized files:
- issue-to-pr-workflow.md (105→6 lines)
- procedure-creation.md (96→6 lines)
- close-issue-procedure.md (93→6 lines)
- git-workflow.md (59→10 lines)
- worktree-workflow.md (36→7 lines)

Closes #1098

Principle: subtraction-creates-value
…stions

Transform 3-line stub into comprehensive retro procedure with:
- Agent-led collaborative process
- Detailed retro questions covering all aspects
- Formatting overhead and tool boundary checks
- Principle tension analysis
- Personality-driven focus (Jonah, Brent, etc.)

Update /retro command to inject full procedure alongside principle.

Closes #1102

Principle: systems-stewardship
…election

Add comprehensive GitHub issue creation workflow that:
- Auto-detects issue type from request keywords
- Maps to appropriate issue templates
- Links relevant procedures based on context
- Provides /create-issue slash command

Updates ai-index.md to reference new procedure for discoverability.

Closes #1100

Principle: systems-stewardship
Captures the 'living system' essence that eagerly evolves. The principle isn't just about incremental improvement - it's about systems that actively seek their own evolution, like a plant growing toward light.

Commit-trailer: Principle: eager-evolution
Update git_add to properly handle deleted files by checking if files
are tracked by git (including deleted files) rather than just checking
if they exist on disk. This matches standard git behavior where
`git add deleted_file` stages the deletion.

Uses git ls-files to get all tracked files and git ls-files --deleted
to specifically find deleted files, allowing them to be staged properly.

Closes #1103

Principle: systems-stewardship
@amazon-q-developer
Copy link
Contributor

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

# Find files that neither exist on disk nor are tracked by git
invalid_files = []
for file in files:
file_path = os.path.normpath(os.path.join(repo_path, file))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Description: Path traversal vulnerability detected. User-controlled input in file paths can allow attackers to access files outside intended directories using ../ sequences. Secure your code by using framework functions like safe_join(), secure_filename() and .startswith() checks. Learn more: https://cwe.mitre.org/data/definitions/22.html

Severity: High

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix uses os.path.realpath() to resolve symlinks and normalize the path, and then checks if the resulting path starts with the repository path to prevent path traversal. This ensures that the file is within the repository directory.

Suggested change
file_path = os.path.normpath(os.path.join(repo_path, file))
# Find files that neither exist on disk nor are tracked by git
invalid_files = []
for file in files:
# Use os.path.realpath to resolve symlinks and normalize the path
file_path = os.path.realpath(os.path.join(repo_path, file)) # import os
if not file_path.startswith(repo_path) or not (os.path.exists(file_path) or file in all_known_files):
invalid_files.append(file)
if invalid_files:

@amazon-q-developer
Copy link
Contributor

✅ I finished the code review, and left comments with the issues I found. I will now generate code fix suggestions.

@atxtechbro atxtechbro merged commit 3fbea35 into main Aug 1, 2025
2 checks passed
@atxtechbro atxtechbro deleted the feature/ai-first-sprint-1106 branch October 10, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sprint: AI-First Dotfiles Enhancement (Aug 1, 2025)

1 participant