Update dependencies action to handle linux running in docker #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| gnome-themes-extra | ||
| ) | ||
|
|
||
| if [ "$(id -u)" -eq 0 ]; then |
There was a problem hiding this comment.
Why do we have this section of the code?
Member
Author
There was a problem hiding this comment.
This is trash, obviously, but that's what I came up with.
This way we detect if the script is running in docker, and for a docker container we need few extra steps, namely disable tz questions during installation, and install sudo, to make the rest of the code work regardless of the runner.
embarc-gabriel
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the linux related logic was moved to
setup_linux.shto ease the handling of different kinds of runners.Tested on Ubuntu 20, 22, 24.