Merged
Conversation
…tion; add UI semaphore utility for managing concurrent access.
The Escape key dismiss handler was inside the same useEffect as the conditions setup (dwell timer, engagement, exit-intent detection). When the popup became visible, the effect re-ran and hit the session cap check (impressions >= cap), causing it to return early without re-registering the Escape handler. The cleanup from the previous render removed the old handler, leaving Escape non-functional. Moved the Escape key handler into its own useEffect that only depends on isVisible, selectedPromo, and resolvedPolicy, ensuring it stays active whenever the popup is visible regardless of session cap state.
- Add role="dialog", aria-modal, and aria-labelledby to the modal - Add focus trap that cycles between dismiss and CTA buttons - Auto-focus the first focusable element on open - Give exit-intent popup id on title element for labelling - Remove isAttentionOverlayLocked gating from conditions setup - Exit-intent now preempts cookie consent (priority 100 > 10) - Cookie consent yields and re-shows after exit-intent dismissal - Remove unused isAttentionOverlayLocked state and subscribe effect
✅ Deploy Preview for audacityteam ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an exit-intent popup on select pages to offer audio.com signup