TST: check total seconds of segmented index#530
Merged
Conversation
Contributor
Reviewer's GuideAdds a new parametrized test ensuring that the total seconds derived from the start/end levels of segmented indexes match the original numeric inputs, and documents the related GitHub issue in the existing dtype test. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
test_segmented_index_seconds, consider converting thestartsandendsparameters tonp.array(..., dtype=float)explicitly before comparison to avoid any ambiguity from mixing ints and floats across parametrizations. - You could add
ids=to the@pytest.mark.parametrizefortest_segmented_index_secondsto make it easier to see which specific case fails when a regression occurs.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `test_segmented_index_seconds`, consider converting the `starts` and `ends` parameters to `np.array(..., dtype=float)` explicitly before comparison to avoid any ambiguity from mixing ints and floats across parametrizations.
- You could add `ids=` to the `@pytest.mark.parametrize` for `test_segmented_index_seconds` to make it easier to see which specific case fails when a regression occurs.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
|
Looks good. I tested locally, and it passes when using I would propose we merge this failing test first and afterwards implement a solution for it. |
hagenw
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a test that checks whether the total seconds of the start and end levels of an index created with
audformat.segmented_index()are as expected. (See #529)Summary by Sourcery
Tests: