Open
Conversation
Co-authored-by: jdluzen <jdluzen@users.noreply.github.com>
…ntrol The DiT was trained with lyrics always set: real lyrics or [Instrumental]. The instrumental flag was a UX convenience that added 4 confusing combinations (instrumental x lyrics) while the model only ever sees one field. - Remove AceRequest::instrumental everywhere (request.h, request.cpp, ace-qwen3.cpp) - lyrics= -> LLM generates (Expand prompt), lyrics=[Instrumental] -> passed as-is, lyrics=... -> used verbatim. No special cases, no silent ignores. - Change duration default from -1 to 0 (all sentinels in code were already > 0) - Document all request fields in README with defaults and runtime semantics This cleans the ground for implementing the remaining LLM modes (Understand, Rewrite) without mixing frontend convenience logic into the backend API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.