Skip to content

XFRFUN follow-up: tighten XfrfunResult.success invariant on message #29

@a2chang

Description

@a2chang

Follow-up from PR #27 (XFRFUN) review at the 3-round cap.

(low) Tighten XfrfunResult.success invariant on message

  • File: src/main/java/com/augment/cbsa/domain/XfrfunResult.java:24
  • The compact constructor permits blank/whitespace strings (e.g. " ") on a successful result, which can mask accidental message propagation.
  • Suggested fix: require message == null for success results (or normalize blank to null) and update tests if needed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions