feat(crecust): translate CRECUST to Java by a2chang · Pull Request #9 · augment-solutions/cbsa-java

a2chang · 2026-05-01T07:18:46Z

Source program: https://github.com/augment-solutions/cics-banking-sample-application-cbsa/blob/main/src/base/cobol_src/CRECUST.cbl

Mapped REST endpoints

POST /api/v1/crecust/insert

Notable decisions

Modeled the COBOL named-counter flow with SELECT ... FOR UPDATE on CONTROL, an optimistic UPDATE, and a Cockroach retry helper around the transaction.
Added strict ddMMuuuu date parsing so impossible calendar dates fail deterministically; kept COBOL-style DOB bounds and introduced fail code Z for invalid calendar dates.
Implemented the five credit-agency calls asynchronously on a virtual-thread executor and return fail code G when all agencies fail or time out.
Added a Flyway migration to back PROCTRAN.COUNTER with a sequence-backed default so audit inserts stay database-managed.
Reused the shared RFC-7807 ProblemDetail error style and typed business exceptions while redacting sensitive abend details from API responses.

COBOL fail-code mappings

T: Invalid Title
G: Credit check error/timeout
3: Named counter ENQ failure
5: Named counter READ failure
A-D: Async child process failures
E: Customer READ failure
F: Customer REWRITE failure
H: Proctran write failure
Z: Invalid Date of Birth (Java-specific addition)

Test coverage

Unit: CrecustServiceUnitTest
@SpringBootTest: CrecustServiceIntegrationTest
MockMvc: CrecustControllerWebMvcTest

a2chang · 2026-05-01T07:18:52Z

augment review

augmentcode · 2026-05-01T07:20:23Z

^{Test Coverage Guardian 🧪}

✅ Test coverage looks good. The new/changed behavior in this PR has adequate test coverage. No additional tests needed.

This PR includes:

CrecustServiceUnitTest: Comprehensive unit tests covering validation logic, error paths, and happy path scenarios
CrecustServiceIntegrationTest: End-to-end integration tests with real database interactions
CrecustControllerWebMvcTest: Web layer tests covering HTTP API, error handling, and security concerns (exception redaction)

All major code paths, edge cases, and error scenarios are properly tested.

augment-app-staging

Review completed. 4 suggestions posted.

Comment augment review to trigger a new review at any time.

augment-app-staging · 2026-05-01T07:24:18Z

+                    .forUpdate()
+                    .fetchOne();
+        } catch (DataAccessException exception) {
+            throw rollbackFailure("3", "Unable to reserve the next customer number.");


Catching DataAccessException here and converting it into a business failure will also swallow Cockroach serialization failures (SQLSTATE 40001), preventing CrdbRetry.run(...) from retrying the transaction under contention.

Severity: high

Other Locations

src/main/java/com/augment/cbsa/repository/CrecustRepository.java:95

src/main/java/com/augment/cbsa/repository/CrecustRepository.java:108

src/main/java/com/augment/cbsa/repository/CrecustRepository.java:125

_{🤖 Was this useful? React with 👍 or 👎}

augment-app-staging · 2026-05-01T07:24:18Z

+        int returnedScores = 0;
+        for (CompletableFuture<Optional<Integer>> future : futures) {
+            try {
+                Optional<Integer> maybeScore = future.join();


Using future.join() with no timeout means one stuck credit-agency call can hang the entire request even though individual failures are otherwise tolerated.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎}

augment-app-staging · 2026-05-01T07:24:18Z

+                customer.creditScore(),
+                toCobolDate(customer.csReviewDate()),
+                "Y",
+                ""


The success response sets CommFailCode to an empty string, but this field looks like a 1-character commarea flag (often a space when unused); returning "" may break clients expecting a single-char value.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎}

augment-app-staging · 2026-05-01T07:24:18Z

+    void createsCustomerAuditTrailAndControlRow() {
+        when(reviewDateRandom.nextInt(20)).thenReturn(3);
+
+        LocalDate today = LocalDate.now(java.time.Clock.systemUTC());


This test computes today using Clock.systemUTC() separately from the service's injected Clock, so it can flake if the date rolls over between the two calls (e.g., around midnight).

Severity: low

_{🤖 Was this useful? React with 👍 or 👎}

augment-app-staging

Review completed. 4 suggestions posted.

Comment augment review to trigger a new review at any time.

augment-app-staging · 2026-05-01T07:24:42Z

+        int returnedScores = 0;
+        for (CompletableFuture<Optional<Integer>> future : futures) {
+            try {
+                Optional<Integer> maybeScore = future.join();


evaluateCredit() uses future.join() without any timeout handling; if a credit-agency call never completes, the request can block indefinitely and never return fail code G. Consider ensuring credit checks complete within a bounded time.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎}

augment-app-staging · 2026-05-01T07:24:42Z

+    }
+
+    private String firstToken(String name) {
+        if (name.isEmpty() || Character.isWhitespace(name.charAt(0))) {


firstToken() returns "" when the name begins with whitespace, which means " Alice Example" bypasses title validation (empty title is allowed) and will be treated as valid. This looks like an input-validation bypass that could allow invalid titles/names to be persisted.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎}

augment-app-staging · 2026-05-01T07:24:42Z

+    }
+
+    private CrecustResult invalidDateFailure(int cobolDate) {
+        int year = Integer.parseInt(String.format("%08d", cobolDate).substring(4));


invalidDateFailure() derives the year via String.format(...).substring(4) and Integer.parseInt(...); for negative cobolDate values this can throw NumberFormatException and turn a validation issue into a 500. Even if the web layer validates non-negative dates, this method is reachable from direct service calls/tests.

Severity: low

_{🤖 Was this useful? React with 👍 or 👎}

augment-app-staging · 2026-05-01T07:24:42Z

+) {
+
+    private static final Set<String> VALIDATION_FAIL_CODES = Set.of("T", "O", "Y", "Z");
+    private static final Set<String> CREDIT_FAIL_CODES = Set.of("A", "B", "C", "D", "E", "F", "G", "H");


CREDIT_FAIL_CODES includes E, F, and H, which appear non-credit-related and are treated as “credit failures” (HTTP 503 / title “Credit check unavailable”) via isCreditFailure(). If those codes are ever returned for persistence/audit failures, clients will receive a misleading 503 rather than an internal error.

Severity: medium

Other Locations

src/main/java/com/augment/cbsa/web/crecust/CrecustController.java:58

src/main/java/com/augment/cbsa/web/crecust/CrecustController.java:77

_{🤖 Was this useful? React with 👍 or 👎}

… recategorize fail codes - evaluateCredit: future.get(timeout) per agency so a hung credit-agency call cannot block the request indefinitely; cancel on timeout/interrupt. - firstToken: stripLeading before tokenizing so a name with leading whitespace cannot bypass title validation by appearing to have an empty (no-title) prefix. - invalidDateFailure: derive year via abs(cobolDate) % 10000 so negative or out-of-range cobolDate inputs cannot turn a validation issue into a 500. - CrecustResult.CREDIT_FAIL_CODES: drop E (customer READ), F (customer REWRITE) and H (proctran write) — those are persistence failures and must fall through to 5xx, not be reported as 503 "Credit check unavailable". Mirror the change in CrecustController.failureTitle.

a2chang · 2026-05-01T07:27:34Z

augment review

augment-app-staging

Review completed. 4 suggestions posted.

Comment augment review to trigger a new review at any time.

augment-app-staging · 2026-05-01T07:35:15Z

+            return CrecustResult.failure("G", "Credit check could not be completed.");
+        }
+
+        Instant now = Instant.now(clock);


create() reads the injected clock multiple times (e.g., LocalDate.now(clock) and later Instant.now(clock)), so around midnight it can validate against one day but persist transactionDate/reviewDate using the next day. Consider deriving today/reviewDate from the same captured instant to avoid rare off-by-one-day behavior.

Severity: low

Other Locations

src/main/java/com/augment/cbsa/service/CrecustService.java:130

src/main/java/com/augment/cbsa/service/CrecustService.java:175

_{🤖 Was this useful? React with 👍 or 👎}

augment-app-staging · 2026-05-01T07:35:15Z

+            } catch (ExecutionException | CompletionException exception) {
+                // Ignore individual credit-agency failures and average only successful replies.
+            } catch (InterruptedException exception) {
+                Thread.currentThread().interrupt();


In evaluateCredit(), after catching InterruptedException the thread is re-interrupted but processing continues; if some scores were already collected, the request can still proceed to create a customer even though cancellation was signaled. Consider treating interruption as an immediate overall credit-check failure (or propagating) to avoid persisting work on interrupted threads.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎}

augment-app-staging · 2026-05-01T07:35:15Z

@@ -0,0 +1,4 @@
+CREATE SEQUENCE IF NOT EXISTS proctran_counter_seq;


This migration creates proctran_counter_seq but doesn’t initialize it to at least max(proctran.counter)+1, so applying it to a database with existing proctran rows can cause default counter values to collide with existing primary keys. Consider bumping/initializing the sequence during migration to make it safe on non-empty environments.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎}

augment-app-staging · 2026-05-01T07:35:15Z

+
+    private String toDescription(CustomerDetails customer) {
+        return customer.sortcode()
+                + String.format("%010d", customer.customerNumber())


toDescription() assumes customerNumber fits in 10 digits via %010d; if customerNumber ever exceeds 9_999_999_999, the formatted string will exceed the intended 40-char proctran.description layout and may fail inserts. Consider enforcing the 10-digit bound when allocating customer numbers to keep the audit description length stable.

Severity: low

_{🤖 Was this useful? React with 👍 or 👎}

…quence init, customer-number bound - CrecustService.create: capture Instant/today once at the start and thread today through validateDateOfBirth and evaluateCredit so all date/time fields derive from the same instant. Avoids rare off-by-one-day audit records when the request straddles midnight. - CrecustService.evaluateCredit: on InterruptedException, set an 'interrupted' flag, restore the interrupt and short-circuit the remaining futures, then return null so we never persist a customer on a thread where cancellation was signaled. - V1__proctran_counter_default.sql: after creating proctran_counter_seq, setval(seq, max(counter)+1, false) so the DEFAULT cannot collide with existing PROCTRAN rows on a non-empty database while preserving the starting value of 1 on an empty table. - CrecustRepository: enforce 10-digit MAX_CUSTOMER_NUMBER bound when allocating the next customer number so the %010d field in the PROCTRAN.DESCRIPTION layout cannot silently overflow.

a2chang · 2026-05-01T07:43:30Z

augment review

augment-app-staging

Review completed. 3 suggestions posted.

Comment augment review to trigger a new review at any time.

augment-app-staging · 2026-05-01T07:49:31Z

+    private static final int REVIEW_DATE_BOUND = 20;
+    private static final long CREDIT_AGENCY_TIMEOUT_SECONDS = 6;
+    private static final List<String> VALID_TITLES = List.of(
+            "Professor", "Mr", "Mrs", "Miss", "Ms", "Dr", "Drs", "Lord", "Sir", "Lady", ""


Including "" in VALID_TITLES means an empty/whitespace-only CommName can pass title validation; since the request DTOs only enforce @NotNull (not non-blank), this could allow persisting customers with blank names.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎}

augment-app-staging · 2026-05-01T07:49:31Z

+        CustomerDetails customer = Objects.requireNonNull(result.customer(), "Successful response requires a customer");
+        return new CrecustResponseDto(new CrecustCommareaResponseDto(
+                EYE_CATCHER,
+                new CrecustKeyDto(Integer.parseInt(customer.sortcode()), customer.customerNumber()),


Integer.parseInt(customer.sortcode()) will throw at runtime if cbsa.sortcode is ever misconfigured/non-numeric, and it will also drop any leading zeros that might be significant for a 6-digit sortcode.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎}

augment-app-staging · 2026-05-01T07:49:32Z

+                    .set(PROCTRAN.AMOUNT, new BigDecimal("0.00"))
+                    .execute();
+        } catch (DataAccessException exception) {
+            throw new com.augment.cbsa.error.CbsaAbendException(


This maps PROCTRAN insert failures to a CbsaAbendException, but elsewhere (e.g., CrecustResult’s documented fail codes) persistence failures appear intended to surface as a CrecustResult fail code (like H). If clients rely on fail codes for audit-write failures, throwing an abend here may bypass that contract.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎}

a2chang · 2026-05-01T07:51:43Z

Auto-review cap reached (3 rounds). Remaining 3 medium suggestions tracked as #10, #11, #12. Merging.

feat(crecust): translate CRECUST to Java

b6145fc

augment-app-staging Bot reviewed May 1, 2026

View reviewed changes

This was referenced May 1, 2026

CRECUST: tighten CommName validation (no blank/whitespace via empty title) #10

Closed

CRECUST: harden sortcode parsing/zero-padding in CrecustController #11

Closed

CRECUST: align PROCTRAN insert failure with documented CrecustResult fail-code contract #12

Closed

a2chang merged commit a3dced2 into main May 1, 2026
1 check passed

a2chang deleted the migrate/CRECUST branch May 1, 2026 07:51

a2chang mentioned this pull request May 1, 2026

CBSA Migration Ledger #3

Closed

22 tasks

		@@ -0,0 +1,4 @@
		CREATE SEQUENCE IF NOT EXISTS proctran_counter_seq;

Conversation

a2chang commented May 1, 2026

Uh oh!

a2chang commented May 1, 2026

Uh oh!

augmentcode Bot commented May 1, 2026

Uh oh!

augment-app-staging Bot left a comment

Choose a reason for hiding this comment

Uh oh!

augment-app-staging Bot May 1, 2026

Choose a reason for hiding this comment

Uh oh!

augment-app-staging Bot May 1, 2026

Choose a reason for hiding this comment

Uh oh!

augment-app-staging Bot May 1, 2026

Choose a reason for hiding this comment

Uh oh!

augment-app-staging Bot May 1, 2026

Choose a reason for hiding this comment

Uh oh!

augment-app-staging Bot left a comment

Choose a reason for hiding this comment

Uh oh!

augment-app-staging Bot May 1, 2026

Choose a reason for hiding this comment

Uh oh!

augment-app-staging Bot May 1, 2026

Choose a reason for hiding this comment

Uh oh!

augment-app-staging Bot May 1, 2026

Choose a reason for hiding this comment

Uh oh!

augment-app-staging Bot May 1, 2026

Choose a reason for hiding this comment

Uh oh!

a2chang commented May 1, 2026

Uh oh!

augment-app-staging Bot left a comment

Choose a reason for hiding this comment

Uh oh!

augment-app-staging Bot May 1, 2026

Choose a reason for hiding this comment

Uh oh!

augment-app-staging Bot May 1, 2026

Choose a reason for hiding this comment

Uh oh!

augment-app-staging Bot May 1, 2026

Choose a reason for hiding this comment

Uh oh!

augment-app-staging Bot May 1, 2026

Choose a reason for hiding this comment

Uh oh!

a2chang commented May 1, 2026

Uh oh!

augment-app-staging Bot left a comment

Choose a reason for hiding this comment

Uh oh!

augment-app-staging Bot May 1, 2026

Choose a reason for hiding this comment

Uh oh!

augment-app-staging Bot May 1, 2026

Choose a reason for hiding this comment

Uh oh!

augment-app-staging Bot May 1, 2026

Choose a reason for hiding this comment

Uh oh!

a2chang commented May 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant