Skip to content

Optimize repo insertion and add repo src id#2929

Merged
sgoggins merged 20 commits intodevfrom
unique-repos
Oct 15, 2024
Merged

Optimize repo insertion and add repo src id#2929
sgoggins merged 20 commits intodevfrom
unique-repos

Conversation

@ABrain7710
Copy link
Copy Markdown
Collaborator

Signed commits

  • Yes, I signed my commits.

Comment thread augur/api/view/api.py
@@ -14,18 +14,6 @@ def cache(file=None):
return redirect(url_for('static', filename="cache"))
return redirect(url_for('static', filename="cache/" + toCacheFilename(file, False)))
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
E0602: Undefined variable 'toCacheFilename' (undefined-variable)

Comment thread augur/api/view/api.py
@@ -2,7 +2,7 @@
import re
from flask_login import current_user, login_required
from augur.application.db.models import Repo, RepoGroup, UserGroup, UserRepo
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0611: Unused RepoGroup imported from augur.application.db.models (unused-import)

Comment thread augur/api/view/api.py
from augur.tasks.frontend import add_github_orgs_and_repos, parse_org_and_repo_name, parse_org_name, add_gitlab_repos
from .utils import *
from ..server import app
from augur.application.db.session import DatabaseSession
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0611: Unused DatabaseSession imported from augur.application.db.session (unused-import)

Comment thread augur/tasks/frontend.py Outdated
add_existing_repo_to_group(logger, session, group_id, repo.repo_id)
continue

add_github_repo(logger, session, url, repo_group_id, group_id, repo_src_id)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
E1120: No value for argument 'repo_src_id' in function call (no-value-for-parameter)

Comment thread augur/tasks/frontend.py

def add_gitlab_repo(session, url, repo_group_id, group_id):

repo_id = Repo.insert_gitlab_repo(session, url, repo_group_id, "Frontend")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
E1120: No value for argument 'repo_src_id' in staticmethod call (no-value-for-parameter)

Comment thread augur/tasks/frontend.py
@@ -1,9 +1,18 @@
import logging
import re
import sqlalchemy as s
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0611: Unused sqlalchemy imported as s (unused-import)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants