feat(jose): remove async keyword from HKDF implementations#21
Merged
halvaradop merged 3 commits intomasterfrom Dec 6, 2025
Merged
feat(jose): remove async keyword from HKDF implementations#21halvaradop merged 3 commits intomasterfrom
async keyword from HKDF implementations#21halvaradop merged 3 commits intomasterfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the
asynckeyword from thederiveKeyandcreateDeriveKeyfunctions in the@aura-stack/josepackage. Theasyncmodifier was unnecessary because the logic inside these functions is entirely synchronous, so keepingasyncprovided no benefit and could cause confusion about their behavior. Removing it makes the API more accurate and efficient.Additionally, the José API Reference documentation has been updated to reflect this change.