fix(EventManager): remove unnecessary dereference#681
Merged
EisenbergEffect merged 1 commit intoaurelia:masterfrom May 28, 2018
Merged
fix(EventManager): remove unnecessary dereference#681EisenbergEffect merged 1 commit intoaurelia:masterfrom
EisenbergEffect merged 1 commit intoaurelia:masterfrom
Conversation
Contributor
|
Can you please comment on why it is unnecessary? |
Contributor
|
possibly unnecessary but have been erring on the side of caution to avoid memory leaks / aid in GC |
Member
Author
|
The class is a disposable object, which could be de-referenced in a single assignment in its consumer. I think it's common practice, hence this PR |
Contributor
|
@bigopon How do we feel? Good to merge this now? |
Member
Author
|
Yes. If its proven to be a source of leaks, we can add this back. I dont know if anyone else is using this new API since the 5th argument needs to be exactly true. And please note that it needs to be disposed exactly the same way with the old subscription: dispose and dereference the subscription, as the old api returns a function that holds reference to all objects used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.