Export ensurePerformance so PLATFORM.performance can be used without initializing jsdom#31
Merged
EisenbergEffect merged 1 commit intoaurelia:masterfrom Oct 20, 2018
timfish:export-ensureperformance
Merged
Export ensurePerformance so PLATFORM.performance can be used without initializing jsdom#31EisenbergEffect merged 1 commit intoaurelia:masterfrom timfish:export-ensureperformance
EisenbergEffect merged 1 commit intoaurelia:masterfrom
timfish:export-ensureperformance
Conversation
Contributor
|
@timfish Was |
Contributor
Author
|
@EisenbergEffect yes, It looks like |
Contributor
Member
|
We had already a fair amount of conversation. This PR being a part of putting the plugin on a diet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aurelia-store uses
PLATFORM.performanceto time and output performance data. When using the store in nodejs, the fullaurelia-pal-nodejsinitialize(), results in 6MB of JavaScript being bundled including jsdom.This change should allow us to init
PLATFORM.performanceon nodejs without bringing in all the other dependencies.Related aurelia-store issue:
aurelia/store#66