Add adapters and improve queue system #2
Conversation
|
@A248 I've set up a large update that does quite a bit (not just adapters but they're a part of this) so go ahead and look for bugs, anything that could be optimized, any strange decisions, etc etc) |
# Conflicts: # pom.xml
core/src/main/java/me/aurium/beetle/branch/centralized/CentralizedManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/me/aurium/beetle/branch/centralized/IllegalSenderException.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * TODO: remove or fix this: i'd preferably like the internal ""initial"" deque to be sealed and immutable | ||
| * It would be nice to enforce immutability on reducablePath except the fact is the reducable path exists | ||
| * to be immutable and edited, so maybe not? Please advise. |
There was a problem hiding this comment.
A Deque is intended to be mutated and manipulated. It doesn't make much sense to have an immutable one. For immutable or read-only access I'd suggest a List.
There was a problem hiding this comment.
The deques will remain mutable then
| <dependency> | ||
| <groupId>org.slf4j</groupId> | ||
| <artifactId>slf4j-api</artifactId> | ||
| <version>2.0.0-alpha1</version> |
There was a problem hiding this comment.
| <version>2.0.0-alpha1</version> | |
| <version>1.7.30</version> |
2.0.0 is a bit of a tough requirement. Libraries usually allow more flexibility in transitive dependency choice. slf4j 1.7 is more widely implemented by logging frameworks than 2.0.0
There was a problem hiding this comment.
I think i moved this over to the test-module (but given your latest comment it will be moved back)
There was a problem hiding this comment.
Yeah, this is a test only dependency so i see no point in using an older version
| * | ||
| */ | ||
|
|
||
| package me.aurium.branch; |
There was a problem hiding this comment.
I don't see why core-tests is a separate module. Usually, same-package unit tests are placed in the same module under src/test/java.
If you do want to use a separate module, you should avoid split packages across modules.
There was a problem hiding this comment.
The reason for core-tests being a separate module is core-tests specific code that is potentially reusable? (string-manager)
core/src/main/java/me/aurium/branch/execution/EmptySuggestionHandler.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public String easyName() { | ||
| return "none"; //TODO perhaps throw? This shouldn't happen. |
There was a problem hiding this comment.
throw if anything which shouldn't happen happens
There was a problem hiding this comment.
the EmptyPermission and EmptyBlock both need reworking on logic
core/src/main/java/me/aurium/branch/nodes/argument/ArgumentConvertet.java
Outdated
Show resolved
Hide resolved
| package me.aurium.branch.nodes.builders; | ||
|
|
||
| /** | ||
| * yet another marker interface |
There was a problem hiding this comment.
You use so many marker interfaces, but it is not clear to me why
There was a problem hiding this comment.
Ensure that correctly typed classes are used where they are desired - an AloneNode is preferred for a no-arguments over just general CommandNode
| * | ||
| */ | ||
|
|
||
| package me.aurium.branch.spigot.message; |
There was a problem hiding this comment.
What purpose do AdventureMessage and FancyTextMessage serve?
There was a problem hiding this comment.
FancyTextMessage will allow for unified pretty formatting (e.g. all commands being red for name, grey for arguments, and a prefix of ""[KitPVP] /lah""
There was a problem hiding this comment.
Implementation will arrive soon!
…vertet.java Co-authored-by: A248 <anandebeh@gmail.com>
|
Removed annotation stuff, probably safe to merge. They will be readded as a separate module eventually. |
No description provided.