Add type-based aliases for power helpers #400
Conversation
Consider the following three options for creating a unit of squared
nanoseconds:
```cpp
using NanoSecondsSquared = decltype(squared(Nano<Seconds>{}));
using NanoSecondsSquared = UnitPowerT<Nano<Seconds>, 2>;
using NanoSecondsSquared = Squared<Nano<Seconds>>;
```
The third one is the most appealing, but it doesn't currently exist.
This PR adds it.
Includes docs.
Fixes #397.
| return root<2>(x); | ||
| } | ||
| template <typename T> | ||
| using Sqrt = decltype(sqrt(std::declval<T>())); |
There was a problem hiding this comment.
Broader question: Is this the name we want to use for these helpers. I know when I see cbrt I have to look up what that means. Our API is pretty fluent, so SquareRoot and CubeRoot wouldn't really be out of place.
There was a problem hiding this comment.
Hmm... I think so?
The argument for the status quo is that cbrt should be consistent with std::cbrt, so we make Cbrt consistent with cbrt. This makes it easier for people to "guess" the rest if they know any of them.
I do agree that for type names, CubeRoot<Nano<Liters>> would be nicer than Cbrt<Nano<Liters>> in a lot of ways, but for now at least I'm finding the consistency argument more persuasive.
There was a problem hiding this comment.
Fair enough. The lower case matching up is obviously plays well with std. And I don't think we should be polluting the namespace with a bunch of aliases. Projects can always provide their own alias if desired.
Consider the following three options for creating a unit of squared
nanoseconds:
The third one is the most appealing, but it doesn't currently exist.
This PR adds it.
Includes docs.
Fixes #397.