Switch Au to new operation-based implementation #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We update `:quantity` so that it simply asks for the right conversion, and applies it. Then, now that we know that `:quantity` is using operations, we can update `:conversion_policy` to use those operations to check for overflow and truncation risk. This lets us get rid of the `:apply_rational_magnitude_to_integral`, `:apply_magnitude`, and `:static_cast_checkers` libraries, because we no longer use them anywhere. However, we retain their _test files_, by sticking a very short implementation (based on the new libraries) at the top of each test file. This way, we still get value from all those old test cases: they give us confidence that we executed the switch correctly. Fixes #349.
hoffbrinkle
approved these changes
Jul 21, 2025
| namespace detail { | ||
| namespace { | ||
|
|
||
| // `NewOverflowChecker<Op>::would_product_overflow(x)` checks whether the value `x` would exceed the |
Member
There was a problem hiding this comment.
Should we add a similar comment about these being from an older library? Obviously git history can be used to check that out, but that would explain the differing idiom for the unit tests (normally they have a corresponding library that they are testing).
Member
Author
There was a problem hiding this comment.
Great point! These files would look really weird otherwise. Done.
|
|
||
| namespace detail { | ||
|
|
||
| template <typename U, typename T> |
Member
There was a problem hiding this comment.
Comment about the previous library implementation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We update
:quantityso that it simply asks for the right conversion,and applies it. Then, now that we know that
:quantityis usingoperations, we can update
:conversion_policyto use those operationsto check for overflow and truncation risk.
This lets us get rid of the
:apply_rational_magnitude_to_integral,:apply_magnitude, and:static_cast_checkerslibraries, because we nolonger use them anywhere. However, we retain their test files, by
sticking a very short implementation (based on the new libraries) at the
top of each test file. This way, we still get value from all those old
test cases: they give us confidence that we executed the switch
correctly.
Fixes #349.