Skip to content

fixed links and footer overlaps#8

Merged
velitchko merged 1 commit intomainfrom
fix/links-and-style
Dec 13, 2025
Merged

fixed links and footer overlaps#8
velitchko merged 1 commit intomainfrom
fix/links-and-style

Conversation

@velitchko
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings December 13, 2025 07:44
@velitchko velitchko merged commit 5ff0b4e into main Dec 13, 2025
2 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes footer overlap issues on mobile devices and corrects email addresses for unsubscribe/help functionality to point to the list owner instead of the request address.

  • Added extra bottom padding to the footer on mobile devices to prevent overlap
  • Updated "Stay Updated" button to link to the newsletter section anchor instead of a non-existent /register route
  • Corrected unsubscribe and help contact email addresses from austrovis-request@ to austrovis-owner@

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
components/Footer.tsx Adds responsive bottom padding (pb-24 on mobile, pb-10 on md+) to fix footer overlap issues
app/page.tsx Changes "Stay Updated" link from /register to #newsletter anchor for proper navigation
app/mailing-list/page.tsx Updates unsubscribe and help contact email addresses to use the owner address instead of request address

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread components/Footer.tsx
return (
<footer className="border-t mt-16 border-black/10 dark:border-[#40444b] darkest:border-white/20">
<div className="max-w-7xl mx-auto px-6 py-10">
<div className="max-w-7xl mx-auto px-6 py-10 pb-24 md:pb-10">
Copy link

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The padding classes are redundant and create potential confusion. The class string contains both py-10 (which sets padding-top and padding-bottom to 2.5rem) and pb-24 (which sets padding-bottom to 6rem). The pb-24 will override the bottom padding from py-10, making the py-10 partially ineffective. Consider using pt-10 pb-24 md:pb-10 instead to make the intent clearer - this explicitly sets top padding to 2.5rem and bottom padding to 6rem on mobile, reducing to 2.5rem on medium screens and above.

Suggested change
<div className="max-w-7xl mx-auto px-6 py-10 pb-24 md:pb-10">
<div className="max-w-7xl mx-auto px-6 pt-10 pb-24 md:pb-10">

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants