Updated auth0-spa-js to latest version#129
Merged
stevehobbsdev merged 2 commits intomasterfrom Jul 3, 2019
Merged
Conversation
luisrudge
suggested changes
Jul 2, 2019
| }, | ||
| "devDependencies": { | ||
| "@auth0/auth0-spa-js": "1.0.0-beta.2", | ||
| "@auth0/auth0-spa-js": "^1.0.1", |
Contributor
There was a problem hiding this comment.
shouldn't this be a dependency instead of devDependency?
Contributor
Author
There was a problem hiding this comment.
@luisrudge Possibly. I've tended to put them in dev dependencies because:
- in development mode you're going to install all the dependencies anyway
- for production, you're likely to do a
build, in which case all the dependencies are bundled anyway.
I've just left the stuff that's needed for the server to work in dependencies, but I'm not overly precious about it. If you think we should rearrange the deps, let me know 👍
Contributor
Author
|
I just added the bump |
luisrudge
approved these changes
Jul 2, 2019
mchang16-auth
pushed a commit
to mchang16-auth/auth0-react-samples
that referenced
this pull request
Feb 27, 2025
Update Node version in Dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.