Use the new release automation solution #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evansims
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds support for the new release automation CLI.
Previously, we were using a custom Fastlane plugin for bumping the version number and updating the Changelog. To bump the version, that plugin uses the
IncrementVersionNumberActionaction from Fastlane. That action uses theagvtool new-marketing-versioncommand to bump the version number. That command will bump the version number in everyInfo.plistfile it can find, regardless of whether it's actually necessary or not:See a previous release of this SDK:
It's bumping the version number of the test target, even though it's not necessary; only the library target's version number needs to be bumped (
JWTDecode/Info.plist).So this PR sets up the version number replacement for
JWTDecode/Info.plistin the.shiprcfile, and sets the version number of the test target to be0.1.0. That means that going forward, each release PR will only be bumping the version number inJWTDecode/Info.plist.Additionally, this PR removes the now-unused Fastlane task.
Testing
[ ] This change adds unit test coverage (or why not)
[ ] This change has been tested on the latest version of the platform/language or why not
Checklist
[ ] I have read the Auth0 general contribution guidelines
[ ] I have read the Auth0 Code of Conduct
[ ] All existing and new tests complete without errors