Skip to content

Expand readme with Style and Options guide#359

Merged
hzalaz merged 3 commits into
v2from
doc_options_walkthrough
Dec 27, 2016
Merged

Expand readme with Style and Options guide#359
hzalaz merged 3 commits into
v2from
doc_options_walkthrough

Conversation

@cocojoe

@cocojoe cocojoe commented Dec 21, 2016

Copy link
Copy Markdown
Member

No description provided.

Comment thread README.md Outdated
#### Scope

Scope used for authentication. By default is `openid`. It will return not only the **access_token**, but also an **id_token** which is a [JSON Web Token (JWT)](https://jwt.io/).
You can add additional attributes to your claim, in this case returning the users `name, email and picture` in the **id_token**. [Scope Resources](https://auth0.com/docs/libraries/lock/v10/sending-authentication-parameters#scope-string-)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's lose this sentence

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, I couldn't find a good source for scope.

Comment thread README.md Outdated

#### Scope

Scope used for authentication. By default is `openid`. It will return not only the **access_token**, but also an **id_token** which is a [JSON Web Token (JWT)](https://jwt.io/).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which is a [JSON Web Token (JWT)](https://jwt.io/) containing some user information.

Comment thread README.md Outdated

You can specify additional parameters that will be sent during an authentication request. [Lock Parameters](https://auth0.com/docs/libraries/lock/v10/sending-authentication-parameters)

* **nonce**: This can be used to help prevent [Replay Attacks](https://en.wikipedia.org/wiki/Replay_attack).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not talk about these parameters since Lock handles more flows than web auth

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall I just drop this section?

Comment thread README.md Outdated
}
```

#### Database Ux

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just Database

Comment thread README.md

#### Custom Signup Fields

When signing up the default information requirements are the user's *email* and *password*. You can expand your data capture requirements as needed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that you need to specify the icon yourself

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was added

Comment thread README.md Outdated
```

In the code above, the *loggerOutput* has been set to use [CleanroomLogger](https://github.com/emaloney/CleanroomLogger). This can typically
be achieved by subclassing *loggerOutput*.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think LoggerOutput is a protocol

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread README.md Outdated
}
```

In the code above, the *loggerOutput* has been set to use [CleanroomLogger](https://github.com/emaloney/CleanroomLogger). This can typically

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you can use your favorite Logger library

Comment thread README.md Outdated
#### Logging

* **logLevel**: By default this is `.off`, *Syslog* logging levels are supported.
* **logHttpRequest**: Log Auth0.swift network requests. By default this is `false`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

network -> authentication/authorization

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to change the option name

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be tempted to simply say API requests as the output is a combination of information. You have signup etc as well.
In that light I think *logAPIRequests might be better. I'm not that bothered about name.

Comment thread README.md Outdated

* **logLevel**: By default this is `.off`, *Syslog* logging levels are supported.
* **logHttpRequest**: Log Auth0.swift network requests. By default this is `false`
* **loggerOutput**: Specify output hander, by default this uses the `print` statement.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hander -> handler

Comment thread README.md Outdated
}
```

## Lock options

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Customization Options

@hzalaz hzalaz merged commit 59fb758 into v2 Dec 27, 2016
@hzalaz hzalaz deleted the doc_options_walkthrough branch December 27, 2016 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants