Conversation
lbalmaceda
approved these changes
Oct 15, 2021
Contributor
Should this be test-covered to verify that the introduced diff fixes that? |
Merged
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Background: When a developer invokes the purge() method on whatever session handler is configured, the chosen session class is expected to clear our the local user session. Developers using the PHP native sessions handler for storage will have the PHP global $_SESSION iterated over and parsed for keys prefixed with the SDK's namespace, which are then deleted.
Bug: This PR addresses an issue in which PHP's language feature
current()will return false when a falsey value is stored in the PHP native session key-store, causing the iteration check ofwhile(current(...))to exit early.Fix: The
key()feature functions as a suitable drop-in replacement for this check without the falsey value issue, allowing the SDK to successfully clear our a user's local session when the developer is using native PHP sessions that contain falsey values.References
Resolves #576
Testing
No additional/new testing was necessary for these changes. Coverage remains at 100%.
Contributor Checklist