Skip to content

607 contrib docs#609

Merged
evansims merged 5 commits intoauth0:mainfrom
sepiariver:607-contrib-docs
Mar 13, 2022
Merged

607 contrib docs#609
evansims merged 5 commits intoauth0:mainfrom
sepiariver:607-contrib-docs

Conversation

@sepiariver
Copy link
Contributor

@sepiariver sepiariver commented Mar 12, 2022

Changes

The CONTRIBUTING.md documentation seems to be outdated as many (all?) of the referenced composer scripts no longer exist. This PR updates the documentation and adds a script in composer to run all php version-specific tests.

Also, for the docker commands to run, docker/entrypoint.sh must be executable. The file's mode was changed to 755

The benefits including hopefully helping contributors get up to speed faster and not face as much of a barrier to entry, potentially leading to higher quality PRs.

Considerations:

References

#607

Resolves #607

Testing

composer tests pass. The new composer tests:phpversions executes all the php version-specific tests and they pass.

Contributor Checklist

@sepiariver sepiariver requested a review from a team as a code owner March 12, 2022 20:16
Copy link
Contributor

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks very much for bringing this up to date!

@evansims evansims merged commit 5c9d22a into auth0:main Mar 13, 2022
@sepiariver sepiariver deleted the 607-contrib-docs branch March 13, 2022 01:39
@evansims evansims mentioned this pull request Apr 25, 2022
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update CONTRIBUTING.md

2 participants