Merged
Conversation
TODO: investigate composer test-integration
evansims
approved these changes
Mar 13, 2022
Contributor
evansims
left a comment
There was a problem hiding this comment.
LGTM! Thanks very much for bringing this up to date!
Merged
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The CONTRIBUTING.md documentation seems to be outdated as many (all?) of the referenced composer scripts no longer exist. This PR updates the documentation and adds a script in composer to run all php version-specific tests.
Also, for the docker commands to run,
docker/entrypoint.shmust be executable. The file'smodewas changed to755The benefits including hopefully helping contributors get up to speed faster and not face as much of a barrier to entry, potentially leading to higher quality PRs.
Considerations:
References
#607
Resolves #607
Testing
composer testspass. The newcomposer tests:phpversionsexecutes all the php version-specific tests and they pass.Contributor Checklist