Skip to content

Conversation

@shushen
Copy link
Contributor

@shushen shushen commented Jan 18, 2021

Description

Additional make targets for build, ci, and build-all-platforms

References

n/a

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@shushen
Copy link
Contributor Author

shushen commented Jan 18, 2021

@cyx the required check might be outdated?

@cyx
Copy link
Contributor

cyx commented Jan 20, 2021

@cyx the required check might be outdated?

I think it's because github actions doesn't let runs happen for folks (for security reasons).

@cyx
Copy link
Contributor

cyx commented Jan 20, 2021

@shushen since I don't have access to your branch, mind pushing to a fork of auth0/auth0-cli instead to exercise the CI build in github actions?

Base automatically changed from master to main January 20, 2021 17:30
@shushen
Copy link
Contributor Author

shushen commented Jan 20, 2021

@shushen since I don't have access to your branch, mind pushing to a fork of auth0/auth0-cli instead to exercise the CI build in github actions?

Sure! I wasn't able to push to auth0/auth0-cli so I created a fork. Interestingly once I pushed and created PR #3, all checks are passing in this PR #2 as well. Probably because they share exactly the same commits so the check results are cached and shared between PRs as well.

@cyx
Copy link
Contributor

cyx commented Jan 21, 2021 via email

@cyx cyx merged commit 1e09143 into auth0:main Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants