feat: include Callbacks on clients create and list #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfatta
commented
Jan 25, 2021
Comment on lines
+125
to
+130
| func apiCallbacksFor(s []string) []interface{} { | ||
| res := make([]interface{}, len(s)) | ||
| for i, v := range s { | ||
| res[i] = v | ||
| } | ||
| return res |
Author
There was a problem hiding this comment.
I wonder if there is a 1-liner to convert from []string to []interface{} 🤔
Contributor
There was a problem hiding this comment.
Nah there's none :) It's the reason the generics troll gets fueled :)
jfatta
commented
Jan 25, 2021
| func (v *clientView) AsTableHeader() []string { | ||
| if v.revealSecret { | ||
| return []string{"Name", "Type", "ClientID", "Client Secret"} | ||
| return []string{"Name", "Type", "ClientID", "Client Secret", "Callbacks"} |
Author
There was a problem hiding this comment.
a refactor here regarding how the columns are included/excluded will be needed at some point (probably not for the PoC)
jfatta
commented
Jan 25, 2021
| func (v *clientView) AsTableRow() []string { | ||
| if v.revealSecret { | ||
| return []string{v.Name, v.Type, ansi.Faint(v.ClientID), ansi.Italic(v.ClientSecret)} | ||
| return []string{ |
Author
There was a problem hiding this comment.
same here, potential combinations are going to make this hard to maintain
jfatta
commented
Jan 25, 2021
Comment on lines
+109
to
+115
| func callbacksFor(s []interface{}) []string { | ||
| res := make([]string, len(s)) | ||
| for i, v := range s { | ||
| res[i] = fmt.Sprintf("%s", v) | ||
| } | ||
| return res | ||
| } |
Author
There was a problem hiding this comment.
is there a simpler way to convert from []interface{} -> []string ?
cyx
reviewed
Jan 25, 2021
cyx
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with --format=json
