Skip to content

Conversation

@shushen
Copy link
Contributor

@shushen shushen commented Jan 25, 2021

Description

  • Replace tail subcommand with -f/--follow option
  • Add -n/--num-entries option to specified number of log entries to show (default 100)
  • Add --no-color option to disable colored output

References

https://auth0team.atlassian.net/browse/A0CLI-22

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@shushen shushen force-pushed the a0cli-22-refine-logs branch from 1dd7415 to c08bab6 Compare January 25, 2021 23:56
@shushen shushen force-pushed the a0cli-22-refine-logs branch from c08bab6 to 24b7f76 Compare January 25, 2021 23:56
@shushen shushen marked this pull request as draft January 25, 2021 23:58
@shushen shushen marked this pull request as ready for review January 25, 2021 23:58
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Have a minor suggestion on copy.

Separately might need to go mod tidy; go mod vendor for the aurora dep.

@shushen
Copy link
Contributor Author

shushen commented Jan 26, 2021

go mod tidy; go mod vendor

It appears have been done in main, a re-run of the commands does not update go.sum:

github.com/logrusorgru/aurora v2.0.3+incompatible h1:tOpm7WcpBTn4fjmVfgpQq0EfczGlG91VSDkswnjF5A8=

Co-authored-by: Cyril David <cyx@users.noreply.github.com>
@shushen shushen merged commit 6b073d8 into main Jan 26, 2021
@shushen shushen deleted the a0cli-22-refine-logs branch January 26, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants