[A0CLI-27] feat: Delete a rule by specifying an ID #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyx
reviewed
Jan 26, 2021
internal/cli/rules.go
Outdated
| }, | ||
| } | ||
|
|
||
| cmd.Flags().StringVarP(&flags.id, "id", "i", "", "ID of the rule to delete (required)") |
Contributor
There was a problem hiding this comment.
Wonder if not having a short form given id is already super short is fine here?
Author
There was a problem hiding this comment.
I was thinking about that... "id" wasn't accepted as that param, so I suppose I just need to leave it as an empty string and perhaps that'll omit the short form? 🤞
cyx
approved these changes
Jan 26, 2021
Contributor
cyx
left a comment
cyx
left a comment
There was a problem hiding this comment.
Have a question re: StringVarP vs StringVar for the command line flag, but otherwise 
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This provides the basic functionality to delete a rule by specifying an ID. In the future, could use the following improvements: