Skip to content

Conversation

@Widcket
Copy link
Contributor

@Widcket Widcket commented Jan 26, 2021

Description

This PR adds interactive prompts for create and update for APIs and rules. If no flags are provided the interactive prompt will kick in; otherwise, flags will work normally.

Interactive

Screen.Recording.2021-01-26.at.20.35.56.mov

Flags

Screen.Recording.2021-01-26.at.20.38.42.mov

@Widcket Widcket changed the title feat: interactive prompts [A0CLI-38] feat: interactive prompts Jan 26, 2021
@Widcket Widcket requested a review from cyx January 26, 2021 23:51
@Widcket Widcket changed the title [A0CLI-38] feat: interactive prompts [A0CLI-38] feat: interactive prompts for APIs and rules Jan 26, 2021
Copy link

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
The only thing I'm not convinced is about disabling the prompter if any flag was passed (discussing here)
But I don't think we need to settle on that for a PoC

@Widcket Widcket merged commit 6559495 into main Jan 27, 2021
@Widcket Widcket deleted the feature/interactive-prompts branch January 27, 2021 00:39
@cyx
Copy link
Contributor

cyx commented Jan 27, 2021

Thanks for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants