[A0CLI-4] feat: initial implementation of try-login #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
paddycarey
changed the title
paddycarey
force-pushed
the
a0cli-4
branch
10 times, most recently
from
fb13079 to
e63f4ae
Compare
cyx
reviewed
Jan 25, 2021
cyx
reviewed
Jan 25, 2021
cyx
reviewed
Jan 25, 2021
cyx
reviewed
Jan 25, 2021
cyx
reviewed
Jan 25, 2021
| m.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) { | ||
| authCode := r.URL.Query().Get("code") | ||
| if authCode == "" { | ||
| _, _ = w.Write([]byte("<p>❌ Unable to extract code from request, please try authenticating again</p>")) |
Contributor
There was a problem hiding this comment.
Can also do fmt.Fprint(w, ...) to avoid the underscore checks IIRC.
cyx
reviewed
Jan 25, 2021
cyx
approved these changes
Jan 25, 2021
Contributor
cyx
left a comment
cyx
left a comment
There was a problem hiding this comment.
Bunch of random non blocking nits, otherwise 
Contributor
|
Hmm, I can't get it to work. What am I doing wrong? Screen.Recording.2021-01-25.at.2.19.57.PM.mov |
Contributor
Author
|
@cyx I added a |
Contributor
Duh! Works now! smooth like pudding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://auth0team.atlassian.net/browse/A0CLI-4
NOTE: This now works, but could probably use some UX/UI love.
try-login-demo-4.mov